Fix tmp files being created in project directory #208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
May 8, 2024
| let makefile_path = toolsdir.join("Makefile.toml"); | ||
| // A temporary directory in the `build` directory | ||
| let build_temp_dir = TempDir::new_in(project.project_dir()) | ||
| let build_temp_dir = TempDir::new_in("/tmp") |
Contributor
There was a problem hiding this comment.
/tmp can be a memory-backed tmpfs so it is unwise to leak files there - and can be pretty annoying to clean up.
Let's use a path like build/.tmp that we recursively delete and create fresh.
Contributor
There was a problem hiding this comment.
Let's use a path like build/.tmp that we recursively delete and create fresh.
Note that an rm -rf "${BUILDSYS_BUILD_DR}/.tmp" needs to be added to Makefile.toml in the appropriate clean task if we do this here. Also, a create_dir_all is probably required here for the build directory because we are doing these things before we go into cargo make.
Contributor
|
This was fixed by #286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #180
Description of changes:
This issue is probably reproducible on every variant (tested on 1) when SIGINT or SIGSTP (or SIGTERM) is called on the build process in a linux host, temp files are not cleared. This is expected behavior as per https://docs.rs/tempfile/latest/tempfile/struct.TempDir.html#resource-leaking as the destructors are never called. The build.rs where these files are created are here.
Instead we will create these files under /tmp as suggested by @webern . This allows us to keep the current build directory clean.
Testing done:
When a
SIGINTorSIGSTP(ctrl+c and ctrl+z) is called, I see the file created in the tmp directory. For example:When no such interruption is provided, watching a directory, I see a file created, then deleted eventually when it goes out of scope.
But eventually it was cleared
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.