fix build variant remove_dir_all and use crate::common::fs #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpculp
approved these changes
Jan 9, 2024
ecpullen
approved these changes
Jan 9, 2024
| let toolsdir = project.project_dir().join("build/tools"); | ||
| tokio::fs::remove_dir_all(&toolsdir).await?; | ||
| tokio::fs::create_dir_all(&toolsdir).await?; | ||
| let _ = fs::remove_dir_all(&toolsdir).await; |
Contributor
There was a problem hiding this comment.
Can you add a comment stating why we are suppressing the remove_dir_all error?
Contributor
Author
|
Remove changes to project1 Twoliter.toml file. |
twoliter build variant produces an error if the tools directory does not exist. This fixes the bug and also uses crate::common::fs for better error messages.
Contributor
Author
jpculp
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
twoliter build variant produces an error if the tools directory does not exist. This fixes the bug and also uses crate::common::fs for better error messages.
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.