Skip to content

Conversation

@ginglis13
Copy link
Contributor

@ginglis13 ginglis13 commented Feb 24, 2025

Issue number:

Description of changes:

Text copied directly from NVIDIA security bulletins
uses a special "non-breaking hyphen" character for
hyphens, resulted in encodings like CVE‑2025‑23359 instead of
using a normal "-" when serializing to XML

Testing done:

Using lint rule added to twoliter, before:

╰─➤  ./tools/twoliter/twoliter make check-advisories --cargo-home /home/fedora/kernel-kit/.cargo --arch $(uname -m)
[2025-02-24T22:54:07Z INFO  twoliter::project::lock] Resolving SDK project reference to check against lock file
[2025-02-24T22:54:07Z INFO  twoliter::project::lock::image] Resolving dependency image dependency 'bottlerocket-sdk-0.50.1@public.ecr.aws/bottlerocket/bottlerocket-sdk:v0.50.1'.
[cargo-make] INFO - cargo make 0.37.22
[cargo-make] INFO -
[cargo-make] INFO - Build File: /home/fedora/kernel-kit/build/tools/Makefile.toml
[cargo-make] INFO - Task: check-advisories
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: check-advisories
advisories/1.0.4/BRSA-4mz3mlhteng6.toml
advisories/1.0.4/BRSA-6jzsr8lqncrq.toml
advisories/1.0.4/BRSA-bl2apnymyndl.toml
advisories/1.0.4/BRSA-jd3wf9wpwu5l.toml
advisories/1.0.4/BRSA-tdebxkarxymw.toml
error: found non-ASCII characters in advisories
Error while executing command, exit code: 1
Error: Command was unsuccessful, exit code 105

After:

╰─➤  ./tools/twoliter/twoliter make check-advisories --cargo-home /home/fedora/kernel-kit/.cargo --arch $(uname -m)
[2025-02-24T22:56:08Z INFO  twoliter::project::lock] Resolving SDK project reference to check against lock file
[2025-02-24T22:56:09Z INFO  twoliter::project::lock::image] Resolving dependency image dependency 'bottlerocket-sdk-0.50.1@public.ecr.aws/bottlerocket/bottlerocket-sdk:v0.50.1'.
[cargo-make] INFO - cargo make 0.37.22
[cargo-make] INFO -
[cargo-make] INFO - Build File: /home/fedora/kernel-kit/build/tools/Makefile.toml
[cargo-make] INFO - Task: check-advisories
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: check-advisories
[cargo-make] INFO - Build Done in 0.20 seconds.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Text copied directly from NVIDIA security bulletins
uses a special "non-breaking hyphen" character for
hyphens, resulted in encodings like CVE‑2025‑23359 instead of
using a normal "-" when serializing to XML

Signed-off-by: Gavin Inglis <giinglis@amazon.com>
@ginglis13 ginglis13 changed the title fix incorrect hyphens used in BRSAs for nvidia kmods fix incorrect hyphens used in BRSAs for nvidia kmods Feb 24, 2025
Copy link
Contributor

@larvacea larvacea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just. Wow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants