Metadata for v0.2.0 #104
Merged
Metadata for v0.2.0 #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelkarp
reviewed
Aug 6, 2021
CHANGELOG.md
Outdated
| @@ -1,3 +1,14 @@ | |||
| # 0.2.0 | |||
|
|
|||
| * Add pagination functionality. | |||
Contributor
There was a problem hiding this comment.
Pagination is the mechanism that we've added support for larger clusters, but not the feature.
Suggested change
| * Add pagination functionality. | |
| * Add support for clusters larger than 50 container instances. |
CHANGELOG.md
Outdated
|
|
||
| * Add pagination functionality. | ||
| * Add after-action summary and done message to log output. | ||
| * Add check to determine if Fargate task is already running. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Add check to determine if Fargate task is already running. | |
| * Add check to reduce the chance of concurrent updater runs. |
CHANGELOG.md
Outdated
| * Add pagination functionality. | ||
| * Add after-action summary and done message to log output. | ||
| * Add check to determine if Fargate task is already running. | ||
| * Add additional unit tests. |
Contributor
There was a problem hiding this comment.
This one isn't a feature.
Suggested change
| * Add additional unit tests. |
CHANGELOG.md
Outdated
| * Add after-action summary and done message to log output. | ||
| * Add check to determine if Fargate task is already running. | ||
| * Add additional unit tests. | ||
| * Update `sendCommand` functionality. |
Contributor
Author
There was a problem hiding this comment.
I may actually remove it since its not really feature related like some of the other callouts you've made.
CHANGELOG.md
Outdated
| * Add check to determine if Fargate task is already running. | ||
| * Add additional unit tests. | ||
| * Update `sendCommand` functionality. | ||
| * Update default Bottlerocket ECS updater version. |
Contributor
There was a problem hiding this comment.
I don't think this one is a feature either.
Suggested change
| * Update default Bottlerocket ECS updater version. |
CHANGELOG.md
Outdated
| * Update `sendCommand` functionality. | ||
| * Update default Bottlerocket ECS updater version. | ||
|
|
||
| Note: In the Bottlerocket ECS updater v0.1.0 release, support for clusters was limited to 50 container instances. In this release, clusters larger than 50 container instances are now supported. |
Contributor
There was a problem hiding this comment.
Might be worth including a 🎉?
- Add v0.2.0 entry - Update README.md to reflect changes in release - Update default version in bottlerocket-ecs-updater.yml
samuelkarp
approved these changes
Aug 6, 2021
gthao313
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Updates CHANGELOG.md, README.md to reflect changes in the release and updates the default version for Bottlerocket ECS updater.
Testing done:
Deployed stack with CloudFormation template and verified new default was applied to parameters as expected. CloudTrail event excerpt displaying the new default image:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.