-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pluto: add proxy support for FIPS #213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on #173. |
Rebased and ready for review. |
ginglis13
approved these changes
Oct 24, 2024
bcressey
reviewed
Oct 25, 2024
Moved proxy logic from |
bcressey
approved these changes
Oct 28, 2024
ginglis13
approved these changes
Oct 28, 2024
ginglis13
reviewed
Oct 28, 2024
arnaldo2792
reviewed
Oct 28, 2024
Replaces `hyper-proxy` with `hyper-http-proxy`. Adds support for hyper client creation using a proxy connector in `aws-smithy-experimental`. Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
|
bcressey
approved these changes
Oct 28, 2024
ginglis13
approved these changes
Oct 28, 2024
arnaldo2792
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related: bottlerocket-os/bottlerocket#1667
Description of changes:
Replaces
hyper-proxy
withhyper-http-proxy
.Adds support for hyper client creation using a custom HTTP connector in
aws-smithy-experimental
.Testing done:
Launched two instances (one built fips and one not) with the following network configuration:
Checked proxy server logs and found all traffic from my private IP being tunneled, including the EKS API calls for
DescribeCluster
.In CloudTrail, I could see that the
DescribeCluster
API call source IP was my proxy server:Testing notes:
If you want to test this on your own, here are a couple of hints:
tinyproxy
for this PR, butsquidproxy
will also work as I used it for testing pluto: Add hyper-proxy as a module bottlerocket#3439.tinyproxy
config, uncomment theLogFile
line and add your EKS cluster's IP range toAllow
.settings.network.https-proxy
to your EC2 host's private IP DNS name and proxy port.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.