-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apiclient/apiserver: add ephemeral-storage commands #15
Merged
yeazelm
merged 1 commit into
bottlerocket-os:develop
from
tzneal:add-ephemeral-storage-apiclient-commands
Sep 4, 2024
Merged
apiclient/apiserver: add ephemeral-storage commands #15
yeazelm
merged 1 commit into
bottlerocket-os:develop
from
tzneal:add-ephemeral-storage-apiclient-commands
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzneal
force-pushed
the
add-ephemeral-storage-apiclient-commands
branch
from
July 2, 2024 17:59
9724e27
to
a2ffe35
Compare
bcressey
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for contributing this!
tzneal
force-pushed
the
add-ephemeral-storage-apiclient-commands
branch
from
July 10, 2024 14:23
a2ffe35
to
0d4177c
Compare
tzneal
force-pushed
the
add-ephemeral-storage-apiclient-commands
branch
from
July 18, 2024 12:45
0d4177c
to
79ac256
Compare
bcressey
reviewed
Aug 13, 2024
tzneal
force-pushed
the
add-ephemeral-storage-apiclient-commands
branch
from
August 13, 2024 13:40
79ac256
to
eaf5931
Compare
tzneal
force-pushed
the
add-ephemeral-storage-apiclient-commands
branch
from
August 13, 2024 14:06
eaf5931
to
213f01f
Compare
5 tasks
bcressey
approved these changes
Sep 3, 2024
arnaldo2792
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #
Description of changes:
Adds apiclient/apiserver commands for initializing ephemeral storage and binding directories to that storage
Testing done:
Updated containerd package to run the new apiclient commands:
I then launched an instance with 0 ephemeral disks, 1 disk, and multiple disks and ensured they all started up correctly. For the instance with > 0 disks, I ensured that our disk was faster:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.