Skip to content

Conversation

doisyg
Copy link

@doisyg doisyg commented Mar 16, 2023

No description provided.

@doisyg doisyg requested review from a team and scheunemann and removed request for a team March 16, 2023 18:21
@doisyg
Copy link
Author

doisyg commented Mar 16, 2023

Approved upstream ros-navigation#3484 following discussion here: ros-navigation#3480

It makes sense to not use the critic at all if the path is empty

Copy link

@scheunemann scheunemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in because it reflects upstream anyway, but will check again later.

@scheunemann scheunemann merged commit 0a5b6af into bau Mar 16, 2023
@scheunemann scheunemann deleted the AUTO-687_fix_path_follow_critics branch March 16, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants