Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the signing config #336

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Conversation

TingDaoK
Copy link
Contributor

https://github.com/awslabs/aws-crt-python/blob/main/awscrt/auth.py#L608-L609

The AwsSigningConfig has default values.

        use_double_uri_encode (bool): Whether to double-encode the resource path
            when constructing the canonical request (assuming the path is already
            encoded). Default is True. All services except S3 use double encoding.

        should_normalize_uri_path (bool): Whether the resource paths are
            normalized when building the canonical request. Default is True.

But, the signing config is for s3, and SDK will encode the URI before pass into CRT, so, set them to false.

@nateprewitt nateprewitt merged commit 1cf8b4d into boto:develop Feb 26, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants