Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: TestBaseManager no longer works under python 3.8+ #258

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cfxegbert
Copy link

Issue #229

This test is no longer needed:

  • Python 3.8+ pickle can not serialize local classes
  • Python 3.8+ can no longer correctly handle manager.start(signal.signal, (signal.SIGINT, signal.SIG_IGN)). It will cause the error PicklingError: Can't pickle <function signal at ...>: it's not the same object as _signal.signal
  • s3transfer no longer calls manager.start as above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant