Add support for None values in list parsing #3618
Open
+57
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When services return lists containing null values (e.g., RDS Data API returning arrays with nulls), the parser would fail with TypeError when attempting to parse primitive types like integers. The fix adds explicit null handling in _handle_list() to preserve null values in the parsed output. Fixes boto/boto3#4508
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3618 +/- ##
===========================================
- Coverage 93.17% 92.67% -0.51%
===========================================
Files 68 68
Lines 15411 15568 +157
===========================================
+ Hits 14359 14427 +68
- Misses 1052 1141 +89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adev-code
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for parsing lists containing null (None) values, which previously caused a TypeError. This issue was discovered with the RDS Data API.
Problem
When a service returns a list with null values e.g.
[123, null, 456], the parser fails with:Solution
Added null value checking in
_handle_list()before attempting to parse items. This fix applies to all parsers.Testing
Unit tests covering:
Fixes boto/boto3#4508