Support # in user_agent_appid
#3588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan343
changed the title
# in user_agent_appid
nateprewitt
approved these changes
Nov 10, 2025
aws-sdk-python-automation
added a commit
that referenced
this pull request
Nov 10, 2025
* release-1.40.70: Bumping version to 1.40.70 Update to latest models Support # in user_agent_appid (#3588)
hswong3i
pushed a commit
to alvistack/boto-botocore
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows hash characters (#) in the
user_agent_appidconfiguration value.Changes
user_agent_appidsanitization logic inbotocore/useragent.pyto preserve hash characters when building the User-Agent string.botocore/config.pyto reflect that#is now an allowed character alongside the existing allowed set.test_hash_in_user_agent_appidintests/unit/test_useragent.pyto verify the behaviorBefore
When setting
user_agent_appid='fooapp#1.0.0', the hash character would be sanitized and replaced with a dash:After
The hash character is now preserved in the
user_agent_appid:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.