Skip to content

Fix typo in configprovider.py #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nateprewitt merged 2 commits into from
Oct 5, 2023
Merged

Fix typo in configprovider.py #3029

nateprewitt merged 2 commits into from
Oct 5, 2023

Conversation

@mgenereu
Copy link
Contributor

@mgenereu mgenereu commented Oct 2, 2023

No description provided.

@nateprewitt
Copy link
Contributor

nateprewitt commented Oct 2, 2023

Hi @mgenereu, thanks for the PR. Unfortunately, this is a breaking change. We've discussed this in #2361 previously. We could add a short note about this for future readers, but otherwise won't be changing the variable name.

@mgenereu
Copy link
Contributor Author

mgenereu commented Oct 5, 2023

@nateprewitt Like that?

@nateprewitt
Copy link
Contributor

nateprewitt commented Oct 5, 2023

Yep, thanks @mgenereu!

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fcad884) 93.39% compared to head (3ef9644) 93.39%.
Report is 17 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3029   +/-   ##
========================================
  Coverage    93.39%   93.39%           
========================================
  Files           66       66           
  Lines        13963    13963           
========================================
  Hits         13041    13041           
  Misses         922      922
Files Coverage Δ
botocore/configprovider.py 94.78% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nateprewitt nateprewitt merged commit 9ae4337 into boto:develop Oct 5, 2023
aws-sdk-python-automation added a commit that referenced this pull request Oct 5, 2023
@aws-sdk-python-automation
Merge branch 'release-1.31.61'
790a48f 
* release-1.31.61:
  Bumping version to 1.31.61
  Update to latest partitions and endpoints
  Update to latest models
  Add notice for typo in configprovider.py (#3029)
  Update retry list (#3032)
@nateprewitt nateprewitt mentioned this pull request Dec 12, 2023
Closed
@nuvious nuvious mentioned this pull request Feb 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nateprewitt nateprewitt nateprewitt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgenereu @nateprewitt @codecov-commenter