Skip to content

Conversation

@jamesls
Copy link
Member

@jamesls jamesls commented Nov 8, 2019

In the case of a throttle error we want to slow down our
request sending rate moreso than exponential backoff. This
commit adds a fixed 10 second minimum delay along with exponential
backoff of 2 ^ retry_attempt seconds.

Verified I could see log messages and expected delays when running these tests in a loop:

tests.integration.test_smoke: DEBUG: Using custom retry delay of: 11

In the case of a throttle error we want to slow down our
request sending rate moreso than exponential backoff.  This
commit adds a fixed 10 second minimum delay along with exponential
backoff of 2 ^ retry_attempt seconds.
@jamesls jamesls requested review from joguSD and kyleknap November 8, 2019 22:52
@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #1882 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1882   +/-   ##
========================================
  Coverage    92.56%   92.56%           
========================================
  Files           53       53           
  Lines        10001    10001           
========================================
  Hits          9257     9257           
  Misses         744      744

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00457e...980f495. Read the comment docs.

@joguSD joguSD merged commit 3a229b8 into boto:develop Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants