Skip to content

Conversation

@tipabu
Copy link
Contributor

@tipabu tipabu commented Oct 24, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 25, 2019

Codecov Report

Merging #1861 into develop will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1861      +/-   ##
===========================================
- Coverage    98.19%   98.18%   -0.01%     
===========================================
  Files           58       58              
  Lines        10843    10843              
===========================================
- Hits         10647    10646       -1     
- Misses         196      197       +1     
Impacted Files Coverage Δ
botocore/configprovider.py 93.37% <100.00%> (ø)
botocore/session.py 98.13% <100.00%> (ø)
botocore/credentials.py 98.54% <0.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d41552...aa2f0c4. Read the comment docs.

@swetashre
Copy link
Contributor

@tipabu - Thank you for the PR. The change looks good. Can you resolve the conflict so that we can merge the PR ?

@swetashre swetashre added response-requested Waiting on additional info and feedback. changes-requested and removed response-requested Waiting on additional info and feedback. labels Oct 23, 2020
@tipabu
Copy link
Contributor Author

tipabu commented Oct 23, 2020

Can you resolve the conflict so that we can merge the PR ?

Thanks for letting me know about the conflict; done.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. label Oct 23, 2020
@swetashre swetashre added pr/ready-to-merge This PR is ready to be merged. and removed changes-requested labels Oct 28, 2020
@joguSD
Copy link
Contributor

joguSD commented Nov 4, 2020

I think we're a little gun shy on making typo fixes like this in variable names. I know in the past it's caused issues for some people despite these variables not being public interfaces really. At the very least to feel comfortable with this change we would need an alias for the old spelling.

@nateprewitt
Copy link
Contributor

Going to resolve this as we haven't seen changes in the last several months and it no longer runs against CI. Please feel free to reopen if there are more changes to review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/ready-to-merge This PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants