Allow parsing of json error responses with non-json bodies. #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Issue boto#908 By catching ValueErrors on json.loads when parsing the error's message body, the raw message can be included as a string. This is not the common case, but errors in an invalid format have been seen in Api Gateway, SWF and Dynamo
Current coverage is 97.57% (diff: 100%)@@ develop #1061 diff @@
==========================================
Files 44 44
Lines 6917 6921 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6749 6753 +4
Misses 168 168
Partials 0 0
|
jamesls
approved these changes
Nov 2, 2016
|
cool. @kyleknap @JordonPhillips: let me know if there are any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #908
By catching ValueErrors on json.loads when parsing the error's message body,
the raw message can be included as a string. This is not the common case,
but errors in an invalid format have been seen in Api Gateway, SWF and Dynamo