Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets- Include ticket Title in transcripts #625

Merged
merged 2 commits into from
Feb 14, 2020

Conversation

Satty9361
Copy link
Contributor

It has been pointed out that finding a transcript using just the ticket number becomes difficult. Adding the ticket title in the filename would resolve this.

@jogramming
Copy link
Contributor

Do you know the max length of the filename?

@jogramming
Copy link
Contributor

Maybe limit it to say 30 chars, using common.CutStringShort(s, len)

@Satty9361
Copy link
Contributor Author

Even stuff like this worked for me:
attachments-2-01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567-0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789.PNG
so i dont think it should be an issue atleast with addition of channel name which has a limited size by itself. With the attachment name maybe some limit can be imposed.

@jogramming
Copy link
Contributor

ah fair enough then

@jogramming jogramming merged commit bdd4740 into botlabs-gg:dev Feb 14, 2020
@Satty9361 Satty9361 deleted the patch-6 branch February 29, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants