Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1796 changed the link regex to catch URL-encoded links such as
https://%20@yagpdb.xyz
. Unfortunately, it caused a regression where text after the URL is matched. The new URL regex matches on the entirety of this text, including the second line:We try to tune the regex so that it catches URL-encoded characters while avoiding the regression. The regex before #1796, after #1796, and after this PR is:
Explicitly, the problem from #1796 is that
\w
and\W
together match on every character. We revert back to the old regex, but expand the character set in the second capturing group per https://stackoverflow.com/a/1547940 so that it still matcheshttps://%20@yagpdb.xyz
.