Skip to content
This repository was archived by the owner on Apr 12, 2018. It is now read-only.

Feature/signals mapper #9

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

Feature/signals mapper #9

wants to merge 22 commits into from

Conversation

ggreg
Copy link
Contributor

@ggreg ggreg commented Mar 20, 2014

Early pull request for comments 📒 and ongoing modifications 🔧 (cc @oleiade).

@oleiade
Copy link
Contributor

oleiade commented Mar 24, 2014

Good to go whenever it passes on travis https://travis-ci.org/botify-labs/process-kit/jobs/21417236 :)

@ggreg
Copy link
Contributor Author

ggreg commented Mar 24, 2014

There is a problem with calling os.waitpid() in the extract_from callback of the process's registry handler, it introduces back a race with the call to os.waitpid() in ProcessOpen.poll().

Consequently if ProcessOpen.poll() calls os.waitpid() first the SIGCHLD handler will not be able to retrieve the handler for the process that exited. It prevents the Process object from resetting its child to None which is the condition to stop waiting in Process.terminate() when wait=True.

@ggreg
Copy link
Contributor Author

ggreg commented Mar 25, 2014

Many unit tests broken. I'm fixing Process.is_alive.

@ggreg
Copy link
Contributor Author

ggreg commented Apr 15, 2014

Oh no! Last commit broke the build 💣! :goberserk:

@oleiade
Copy link
Contributor

oleiade commented Apr 16, 2014

Doge build

@oleiade
Copy link
Contributor

oleiade commented Apr 28, 2014

PR is still broken according says travis, what about it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants