ENH: Implement binary path #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhslepicka
requested changes
May 8, 2023
Contributor
hhslepicka
left a comment
hhslepicka
left a comment
There was a problem hiding this comment.
Just a small request to validate the input.
We also need a documentation Pull Request to update the browser configuration section in order to highlight this new feature.
botcity/web/bot.py
Outdated
| Args: | ||
| binary_path (str): The binary path to be used. | ||
| """ | ||
| self._binary_path = pathlib.Path(binary_path) |
Contributor
There was a problem hiding this comment.
We need to validate the binary_path parameter to ensure that it exists and is a valid file before assigning it.
hhslepicka
requested changes
May 8, 2023
Contributor
hhslepicka
left a comment
hhslepicka
left a comment
There was a problem hiding this comment.
Just a small request to validate the input.
We also need a documentation Pull Request to update the browser configuration section in order to highlight this new feature.
hhslepicka
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can pass the location of the binary you want to run.
This opens up possibilities:
Run any Chrome-based Browser (Brave, Vivaldi, OperaGX, Chrome Beta, etc.)
Run any Firefox Based Browser (Tor, LibreWolf, Firefox Beta)
(Warning: Tor needs some additional settings to connect to Tor Network first)