ENH: Added methods to support pywinauto features #26
Conversation
There was a problem hiding this comment.
An idea that can be inserted in this context is that of modularization.
What do you think about creating a module just for the application and using it to call these functions within the core?
In that situation we would have more code isolation and allow for better maintenance.
botcity/core/application.py
Outdated
| """ | ||
| @wraps(func) | ||
| def wrapper(self, *args, **kwargs): | ||
| if platform.system() != "Windows": |
There was a problem hiding this comment.
What do you think about changing the if negation to something more solid? For example:
| if platform.system() != "Windows": | |
| if plataform.system() == "Windows": | |
| return func(self, *args, **kwargs) | |
| raise ValueError(f'You can connect to an application on Windows OS only. Cannot invoke {func.__name__}.') |
That way the name of the function is more objective. What do you think of this proposal?
There was a problem hiding this comment.
@kayqueGovetri good observations! I was thinking of including the methods in the application.py I had created, leaving it along with the Backend enum and validation decorators. That way, everything would be concentrated in the same 'application' module.
Do you think it would be a good strategy? Or would it be more interesting to leave the methods separate?
There was a problem hiding this comment.
@joao-voltarelli It's a good alternative to make a preview of how it would look.
Something I could do to make it more isolated would be to create sub levels for each situation, for example:
- application.py can become a package application/
- Inside the package it can contain:
- The enums.
- The decorators.
- The functions.
- A
___init__.py file containing the__all__method to make exporting files easier.
What do you think of this approach? It might be more work but I think it's worth the result.
There was a problem hiding this comment.
It was an alternative that I was considering as well, it would make it easier to include future implementations of functions, decorators...
I'll take a look at these options and see how it gets better organized.
|
We need to find a way to conditionally add the dependency on the Suggestions:
|
3 participants
Added initial version of supported methods for pywinauto.
connect_to_app: Connects to an instance of an open application.find_app_window: Find a window of the currently connected application using the available selectors.find_app_element: Find a element of the currently connected application using the available selectors.