Skip to content

change sendRequestInternal from private to protected#380

Merged
ex0ns merged 1 commit into
bot4s:mainfrom
cobr123:change_send_request_internal_to_protected
Mar 29, 2024
Merged

change sendRequestInternal from private to protected#380
ex0ns merged 1 commit into
bot4s:mainfrom
cobr123:change_send_request_internal_to_protected

Conversation

@cobr123
Copy link
Copy Markdown
Contributor

@cobr123 cobr123 commented Mar 14, 2024

This PR provide a change of sendRequestInternal method from private to protected for opportunity to override apply method without copying of sendRequestInternal method.

…to override apply method without copying of sendRequestInternal method
@ex0ns
Copy link
Copy Markdown
Contributor

ex0ns commented Mar 29, 2024

Sorry for the delay, I missed the notification
I don't really see any issue with this changes, and that would enable user to add new/not yet supported messages

Thanks for the PR, going to publish a new version asap

@ex0ns ex0ns merged commit b324306 into bot4s:main Mar 29, 2024
@ex0ns
Copy link
Copy Markdown
Contributor

ex0ns commented Mar 29, 2024

version 5.8.0 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants