Run frontend locally #435
Merged
Run frontend locally #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eted (seen with ganache)
…or a transaction already completed (seen with ganache)". Instead we advise to run Ganache with blockTime=5sec
levalleux-ludo
requested review from
LuboslavBurdenski,
damir-bajramovic and
dennisfurrer
| }; | ||
|
|
||
| export const NETWORK_ID = 4; | ||
| export const SUPPORTED_CHAIN_IDS = [4, 1337]; |
Contributor
There was a problem hiding this comment.
This might be an issue - EIP712 message signing could be impeded, due to a, most definitely, a bug on the Ganache network.
While I was working on the contracts-sdk, I encountered an issue with the Ganache network ID. You can find the example here. The Ganache network has a default network ID of 1 - same as the Homestead network, which is disgusting. It could be an issue. I'm checking if it really is an issue.
dennisfurrer
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana cards: https://app.asana.com/0/1199560399769920/1200544206392313
https://app.asana.com/0/1199560399769920/1200446754208594