Skip to content

Conversation

@levalleux-ludo
Copy link
Member

@levalleux-ludo levalleux-ludo commented Nov 10, 2025

Description

Added metaTxApiId optional property to PreMintButton component to enable custom Biconomy API ID configuration for meta-transactions.

Changes:

  • Added metaTxApiId?: string to component props and type definitions (lines 24, 28, 47)
  • Passed metaTxApiId to relayBiconomyMetaTransaction via metaTxConfig.apiId override (lines 84-86)

This allows consumers to specify a different Biconomy API ID per button instance when the default configuration is insufficient.

How to test

import { PreMintButton } from "@bosonprotocol/react-kit";

// Use custom Biconomy API ID for meta-transaction
<PreMintButton
  offerId="123"
  amount={5}
  metaTxApiId="custom-api-id-here"
  onSuccess={(receipt) => console.log("Success", receipt)}
/>

Verify the custom API ID is used in the Biconomy relay call when meta-transactions are enabled.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.98%. Comparing base (7188cf3) to head (9b53ee7).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
+ Coverage   86.39%   90.98%   +4.58%     
==========================================
  Files         167      176       +9     
  Lines        7095     7190      +95     
  Branches     1299     1322      +23     
==========================================
+ Hits         6130     6542     +412     
+ Misses        965      648     -317     
Flag Coverage Δ
common 92.59% <ø> (?)
core-sdk 56.41% <ø> (?)
e2e 86.08% <ø> (+<0.01%) ⬆️
eth-connect-sdk 95.06% <ø> (?)
ethers-sdk 74.45% <ø> (?)
ipfs-storage 91.75% <ø> (ø)
metadata 94.70% <ø> (ø)
unittests 60.76% <ø> (-32.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@levalleux-ludo
Copy link
Member Author

@copilot

Copy link
Contributor

Copilot AI commented Nov 10, 2025

@levalleux-ludo I've opened a new pull request, #991, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ levalleux-ludo
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

@levalleux-ludo levalleux-ludo merged commit 75330c3 into main Nov 10, 2025
6 of 7 checks passed
@levalleux-ludo levalleux-ludo deleted the fix-permint-meta-tx branch November 10, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants