Skip to content

Conversation

@levalleux-ludo
Copy link
Member

Description

{{what was done}}

How to test

{{how can it be tested}}

@levalleux-ludo levalleux-ludo self-assigned this Nov 5, 2025
@levalleux-ludo levalleux-ludo marked this pull request as ready for review November 5, 2025 14:54
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.98%. Comparing base (b658f3d) to head (37713e7).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #983   +/-   ##
=======================================
  Coverage   90.98%   90.98%           
=======================================
  Files         176      176           
  Lines        7187     7187           
  Branches     1322     1322           
=======================================
  Hits         6539     6539           
  Misses        648      648           
Flag Coverage Δ
common 92.51% <ø> (ø)
core-sdk 56.41% <ø> (ø)
e2e 86.07% <ø> (ø)
eth-connect-sdk 95.06% <ø> (ø)
ethers-sdk 74.45% <ø> (ø)
ipfs-storage 91.75% <ø> (ø)
metadata 94.70% <ø> (ø)
unittests 60.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@levalleux-ludo
Copy link
Member Author

@copilot

Copy link
Contributor

Copilot AI commented Nov 5, 2025

@levalleux-ludo I've opened a new pull request, #985, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for price discovery offers in the Boson Protocol, which are offers where the price is determined dynamically rather than being static. The changes include new UI components for managing price discovery ranges and pre-minting vouchers, as well as updates to display price discovery offers with special formatting (showing "Price on discovery" with "??" instead of a numeric price).

Key changes:

  • Adds two new CTA button components: ReserveRangeButton and PreMintButton for managing price discovery functionality
  • Updates price display logic to show "Price on discovery" with "??" for discovery-type offers
  • Disables commit buttons for price discovery offers
  • Adds minted field to GraphQL subgraph queries for range tracking
  • Removes unused BOSON_META_TX_ABI environment variable from docker-compose

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react-kit/src/components/cta/offer/ReserveRangeButton.tsx New component for reserving ranges in price discovery offers
packages/react-kit/src/components/cta/offer/PreMintButton.tsx New component for pre-minting vouchers for price discovery offers
packages/react-kit/src/stories/cta/offer/ReserveRangeButton.stories.tsx Storybook story for ReserveRangeButton component
packages/react-kit/src/stories/cta/offer/PreMintButton.stories.tsx Storybook story for PreMintButton component
packages/react-kit/src/index.tsx Exports new ReserveRangeButton and PreMintButton components
packages/react-kit/src/components/price/Price.tsx Adds conditional rendering for price discovery offers showing "Price on discovery"
packages/react-kit/src/components/productCard/ProductCard.tsx Adds isPriceDiscoveryOffer prop and passes it to CurrencyDisplay
packages/react-kit/src/components/currencyDisplay/CurrencyDisplay.tsx Displays "??" for price discovery offers instead of numeric value
packages/react-kit/src/components/modal/components/common/detail/DetailViewCore.tsx Passes price discovery flag to Price component in detail view
packages/react-kit/src/components/modal/components/common/OfferFullDescription/GeneralProductData.tsx Passes price discovery flag to Price component in product data
packages/react-kit/src/components/modal/components/Commit/DetailView/InnerCommitDetailView.tsx Disables commit button for price discovery offers
packages/react-kit/src/components/modal/components/Commit/DetailView/InnerCommitDetailViewWithPortal.tsx Disables commit button for price discovery offers in portal view
packages/react-kit/src/stories/ProductCard.stories.tsx Adds isPriceDiscoveryOffer prop to story args
packages/core-sdk/src/subgraph.ts Adds minted field to all RangeEntity fragments in generated GraphQL types
packages/core-sdk/src/offers/queries.graphql Adds minted field to BaseRangeFields fragment
e2e/docker-compose.yml Removes unused BOSON_META_TX_ABI environment variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@levalleux-ludo levalleux-ludo merged commit 7188cf3 into main Nov 5, 2025
17 of 19 checks passed
@levalleux-ludo levalleux-ludo deleted the react-kit-add-premint-vouchers branch November 5, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants