feat(version): read app info from package.json

[AvinashReddy3108]

Basically, an extension of this commit for other applicable fields in the AppInfo array.

[AvinashReddy3108]

One possible extensions to this PR

• populate AppInfo fields only from package.json .. like so (also removing related variables from the .env file)

const AppInfo = {
  APP_VERSION: readPackageJsonSync().version,
  APP_NAME: readPackageJsonSync().name,
  APP_DESCRIPTION: readPackageJsonSync().description,
  AUTHOR_NAME: readPackageJsonSync().author?.name,
  AUTHOR_EMAIL: readPackageJsonSync().author?.email,
  AUTHOR_WEBSITE: readPackageJsonSync().author?.url
};

But I was hesitant to make this change for now as I don't know the reason behind you using environment variables for these stuff..

[borjapazr]

One possible extensions to this PR

• populate AppInfo fields only from package.json .. like so (also removing related variables from the .env file)

const AppInfo = {
  APP_VERSION: readPackageJsonSync().version,
  APP_NAME: readPackageJsonSync().name,
  APP_DESCRIPTION: readPackageJsonSync().description,
  AUTHOR_NAME: readPackageJsonSync().author?.name,
  AUTHOR_EMAIL: readPackageJsonSync().author?.email,
  AUTHOR_WEBSITE: readPackageJsonSync().author?.url
};

But I was hesitant to make this change for now as I don't know the reason behind you using environment variables for these stuff..

Hi @AvinashReddy3108 ! First of all, thank you for your PR. I think it is a very good idea 👌 Anyway, before merge the PR it is necessary to correct the problems reported by tsc.

The environment variables are there to provide an option to overwrite all this information. For example, imagine that when you are going to deploy the application in a productive environment you prefer to show the information of the company and not of the developer who implemented the application. In this way, unless overwritten, the package.json data will always be shown, but if we want others for any reason, they could be provided in a very simple way.

[AvinashReddy3108]

Anyway, before merge the PR it is necessary to correct the problems reported by tsc.

Never faced those issues in my local machine (node 18.x), but tried to solve them nonetheless.

PS: the PR's commit history looks embarrassing (sorry about that), please "Squash and Merge" if the CI runs pass.

[AvinashReddy3108]

The environment variables are there to provide an option to overwrite all this information. For example, imagine that when you are going to deploy the application in a productive environment you prefer to show the information of the company and not of the developer who implemented the application. In this way, unless overwritten, the package.json data will always be shown, but if we want others for any reason, they could be provided in a very simple way.

@borjapazr I also updated the .env file with the related variables (these are commented out by default)

But won't it be better if there's a .env.sample tracked by version control, and then .env in the .gitignore (As the .env contains sensitive info like database passwords and stuff)