Built-In support for Gitlab

[kiview]

Is this something you would consider valuable for this plugin?
Just something along the 3 steps explained in the README in a more automated way and maybe global configs for something like the Gitlab user token.

I could however also understand if you want to prevent feature creep, since other users might want to integrate with different applicataions like Bitbucket or Github as well.

[borisdiakur]

I think it would be cool if marked had some connectors (like a GitLab-connector, Bitbucket-connector etc.) to connect more conveniently to these services. Currently I do not have much time to contribute, but I’d be happy to merge any PR.

[kiview]

Ok good to now. I'll try to get some time committed to do this at work, this shouldn't be too hard.

[jasango]

I'm trying to integrate marked with bitbucket with no success, Basic Auth or Token based auth not currently supported in bitbucket, REST API does not provide a simple way to get a git resource, now I have a simple java code which authenticate succefully on bitbucket login servlet using Apache Http Client. If we make the auth request before the fetch request we can get any markdown from bitbucket. I'm thinking to do in this way: pass auth information as suffix in marked input url like: http://[current-url/?bbusr=xxx bbpwd=yyy. Could you please tell me if you are willing to accept this way to make that change and a pull request?

[kiview]

I would prefer a more explicit Bitbucket connector, and not some implicit hacks based on Url format. But AFAIK there were already lot's of fully supported Bitbucket Addons for Confluence in the Marketplace? Maybe no open source ones though...

[borisdiakur]

@jasango Bitbucket has support for OAuth 2 and Basic Auth, see https://developer.atlassian.com/bitbucket/api/2/reference/meta/authentication

[jasango]

Hi Boris, thanks for that info, Im gonna analyze it better, of course it would be smarter solution than go through the servlet, the problem I saw was that the rest API does not provide a mechanism to fecht a resource (markdown), I think it only allows operations on bitbucket entities, but Im gonna review that in a couple of days and I will tell you. Maybe after an API authentication the same connection can get the resource like the browser.

[borisdiakur]

@jasango Thanks for your pull request. Still I think this is not the way to go. I would prefer a token based solution using connectors over basic auth. BitBucket does support access to private resource via the API. Here is basically how it works:

1. Create a consumer.
2. With the client id of that consumer, get the access token: https://bitbucket.org/site/oauth2/authorize?client_id={key}&response_type=token
3. Get the raw file via the bitbucket api: https://api.bitbucket.org/1.0/repositories/{accountname}/{repo_slug}/raw/{revision}/{path}?access_token={access_token}

Since on bitbucket access tokens expire in one hour, the connector would have to make use of refresh tokens as well.

[jasango]

Hi Boris, thanks for your review, I was evaluating OAuth2 but discarded because I was not able to generate that consumer. I do not even have that OAuth menu bar in my bitbucket account settings. Maybe because I use a "on premise" bitbucket installation. I think as well that OAuth2 would be a too complex solution to only get a simple resource and disconnect,. the solution Im providing is very simple, one connection with Basic Auth and get a Json Object with an array of lines. I'm not very clear about the meaning of license of your project could you please tell me if I can change the name of it and upload to "bitbuckets add-ons" with different name? Regards, Javier

[kiview]

It's BSD 3 license, so this should be fine. Can we continue the discussion inside #11 , since this issue is about Gitlab? 😉