Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrateMeasurement() data frame unclear #768

Closed
hmellor opened this issue May 25, 2021 · 3 comments · Fixed by #771
Closed

integrateMeasurement() data frame unclear #768

hmellor opened this issue May 25, 2021 · 3 comments · Fixed by #771

Comments

@hmellor
Copy link
Contributor

hmellor commented May 25, 2021

Description

In CombinedImuFactorsExample.cpp it is stated that the IMU data is provided aligned to NED (the navigation frame).

However, the documentation for gtsam::PreintegratedCombinedMeasurements::integrateMeasurement() states that the IMU data should be provided in body frame.

Only one of these can be correct and I am uncertain which is.

@tmcg0
Copy link
Contributor

tmcg0 commented May 27, 2021

Measurements should be provided in the body frame. I think the example file comment is just misleading---perhaps the referenced comment line should end names in X, Y, Z instead of N, E, D.

@mikesheffler
Copy link
Contributor

Agreed. Saying 'N, E, D', may have been the author's way of describing a coordinate system that could perhaps be more accurately described as 'forward, right, down'. At least, I know I've made that specific whoopsie :)

@tmcg0
Copy link
Contributor

tmcg0 commented May 28, 2021

@hmellor you could always make a PR that cleans up that comment. :) clarity is always a plus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants