VC 2016 compile bug?

[dellaert]

Description

It seems VC 2016 fails to complete check after @Alexma3312 ’s PR was merged:

Event.cpp
1114
D:\a\gtsam\gtsam\gtsam/geometry/Point3.h(69): error C2491: 'gtsam::mean': definition of dllimport function not allowed (compiling source file D:\a\gtsam\gtsam\gtsam_unstable\geometry\BearingS2.cpp) [D:\a\gtsam\gtsam\build\gtsam_unstable\gtsam_unstable.vcxproj]
1115
D:\a\gtsam\gtsam\gtsam/geometry/Point3.h(69): error C2491: 'gtsam::mean': definition of dllimport function not allowed (compiling source file D:\a\gtsam\gtsam\gtsam_unstable\geometry\Event.cpp) [D:\a\gtsam\gtsam\build\gtsam_unstable\gtsam_unstable.vcxproj]
1116
  Pose3Upright.cpp

[Alexma3312]

I think the reason is the gtsam::mean is defined in the .h file. One fix will be moving the function definition to the .cpp file.
https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2491?view=vs-2019

template <class CONTAINER>
GTSAM_EXPORT Point3 mean(const CONTAINER& points) {
  if (points.size() == 0) throw std::invalid_argument("Point3::mean input container is empty");
  Point3 sum(0, 0, 0);
  sum = std::accumulate(points.begin(), points.end(), sum);
  return sum / points.size();
}

[dellaert]

I think the issue is the name conflict. I am fixing in a branch now...

[ProfFan]

Should this be closed?

[dellaert]

Fixed in #549