Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build with msvc and C++20 #1788

Open
asmei1 opened this issue Aug 5, 2024 · 1 comment
Open

Cannot build with msvc and C++20 #1788

asmei1 opened this issue Aug 5, 2024 · 1 comment
Labels
bug Bug report

Comments

@asmei1
Copy link

asmei1 commented Aug 5, 2024

Description

I'm trying to build GTSAM library using conan 1.62.0 using C++20. Compilation fails on gtsam/base/chartTesting.h file.
There is a function testDefaultChart used in CHECK_CHART_CONCEPT macro.

To be more specific, compilation fails on gtsam::DefaultChart<T>. But what is weird for me that none of above types (function, macro, gtsam::DefaultChart<T> type) is not used anywhere. The error was exactly the same as in this comment.

When I remove this file, everything compiles. I think that this file is leftover after some cleaning and it should be removed in future

Steps to reproduce

  1. Build GTSAM with msvc, with C++20, build tools v143.

Expected behavior

Successful build

Environment

Gtsam (I tried 4.0.2, 4.0.3, 4.2)
Windows
MSVC; v143
C++20
conan 1.62.0
cmake 3.27.1

Additional information

@ProfFan ProfFan added the bug Bug report label Aug 14, 2024
@adam-brz
Copy link

adam-brz commented Sep 6, 2024

I've also stumbled upon this issue. It would be nice to further investigate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

3 participants