Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo issue in comments #1201

Closed
huanglilong opened this issue May 19, 2022 · 4 comments
Closed

typo issue in comments #1201

huanglilong opened this issue May 19, 2022 · 4 comments

Comments

@huanglilong
Copy link
Contributor

gtsam/gtsam/geometry/Rot3.cpp

Line 295 in da00870

// c20 = a10 * cy + a11 * sx * sy + a12 * cx * sy

gtsam/gtsam/geometry/Rot3.cpp

Line 296 in da00870

// c22 = a11 * cx - a12 * sx

should be
// c10 = a10 * cy + a11 * sx * sy + a12 * cx * sy
// c11 = a11 * cx - a12 * sx
image
@huanglilong
Copy link
Contributor Author

@Eskilade typo issue in comments.

@Eskilade
Copy link
Contributor

Indeed, thanks !

@varunagrawal
Copy link
Collaborator

@huanglilong can you please make a PR? I'll happily review and help merge it in. Bonus: you get to call yourself a GTSAM contributor.

@huanglilong
Copy link
Contributor Author

@varunagrawal @Eskilade please review this diff #1206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@varunagrawal @huanglilong @Eskilade