Remove test workaround from list_repo.py, add proper error handling (#2392)#2393
Open
mr-raj12 wants to merge 1 commit intoborgbase:masterfrom
Open
Remove test workaround from list_repo.py, add proper error handling (#2392)#2393mr-raj12 wants to merge 1 commit intoborgbase:masterfrom
mr-raj12 wants to merge 1 commit intoborgbase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove test-specific workaround from production code and fix the underlying test infrastructure issue.
Changes:
if not result['data']: result['data'] = {}workaround, add proper error handling with logging for unexpected datatypes
mock_borg_popenfixture that provides fresh file handles for each Popen call, supporting job chaining scenariostest_repo_pruneto use new fixture (prune triggers list refresh = 2 jobs)Related Issue
Closes #2392
Motivation and Context
Production code contained a test-specific workaround that silently masked potential errors. The root cause was test infrastructure reusing file handles across
chained jobs - when job A (prune) read from a file handle, job B (list) would get empty content because the file position was at EOF.
How Has This Been Tested?
ruff check)os.set_blocking()which doesn't work on WindowsTypes of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.