Skip to content

Speed up benchmark cpu tests with _BORG_BENCHMARK_CPU_TEST env var #9417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toroleapinc wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −10
Open

Speed up benchmark cpu tests with _BORG_BENCHMARK_CPU_TEST env var #9417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/borg/archiver/benchmark_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,13 @@ def do_benchmark_cpu(self, args):

result = {} if args.json else None

random_10M = os.urandom(10 * 1000 * 1000)
is_test = "_BORG_BENCHMARK_CPU_TEST" in os.environ
# Use minimal iterations and data size in test mode to keep CI fast.
number_default = 1 if is_test else 100
number_compression = 1 if is_test else 10
data_size = 100 * 1000 if is_test else 10 * 1000 * 1000

random_10M = os.urandom(data_size)
key_256 = os.urandom(32)
key_128 = os.urandom(16)
key_96 = os.urandom(12)
Expand Down Expand Up @@ -202,7 +208,7 @@ def chunkit(ch):
),
("fixed,1048576", "ch = get_chunker('fixed', 1048576, sparse=False)", "chunkit(ch)", locals()),
]:
dt = timeit(func, setup, number=100, globals=vars)
dt = timeit(func, setup, number=number_default, globals=vars)
if args.json:
algo, _, algo_params = spec.partition(",")
result["chunkers"].append({"algo": algo, "algo_params": algo_params, "size": size, "time": dt})
Expand All @@ -218,7 +224,7 @@ def chunkit(ch):
size = 1000000000
tests = [("xxh64", lambda: xxh64(random_10M)), ("crc32 (zlib)", lambda: crc32(random_10M))]
for spec, func in tests:
dt = timeit(func, number=100)
dt = timeit(func, number=number_default)
if args.json:
result["checksums"].append({"algo": spec, "size": size, "time": dt})
else:
Expand All @@ -235,7 +241,7 @@ def chunkit(ch):
("hmac-sha256", lambda: hmac_sha256(key_256, random_10M)),
("blake2b-256", lambda: blake2b_256(key_256, random_10M)),
]:
dt = timeit(func, number=100)
dt = timeit(func, number=number_default)
if args.json:
result["hashes"].append({"algo": spec, "size": size, "time": dt})
else:
Expand Down Expand Up @@ -275,7 +281,7 @@ def chunkit(ch):
),
]
for spec, func in tests:
dt = timeit(func, number=100)
dt = timeit(func, number=number_default)
if args.json:
result["encryption"].append({"algo": spec, "size": size, "time": dt})
else:
Expand All @@ -285,7 +291,7 @@ def chunkit(ch):
print("KDFs (slow is GOOD, use argon2!) ===============================")
else:
result["kdf"] = []
count = 5
count = 1 if is_test else 5
Copy link
Member

@ThomasWaldmann ThomasWaldmann Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to number_kdf and move the line close to the others.

for spec, func in [
("pbkdf2", lambda: FlexiKey.pbkdf2("mypassphrase", b"salt" * 8, PBKDF2_ITERATIONS, 32)),
("argon2", lambda: FlexiKey.argon2("mypassphrase", 64, b"S" * ARGON2_SALT_BYTES, **ARGON2_ARGS)),
Expand Down Expand Up @@ -319,7 +325,7 @@ def chunkit(ch):
]:
compressor = CompressionSpec(spec).compressor
size = 100000000
dt = timeit(lambda: compressor.compress({}, random_10M), number=10)
dt = timeit(lambda: compressor.compress({}, random_10M), number=number_compression)
if args.json:
algo, _, algo_params = spec.partition(",")
result["compression"].append({"algo": algo, "algo_params": algo_params, "size": size, "time": dt})
Expand All @@ -334,7 +340,7 @@ def chunkit(ch):
items = [item.as_dict()] * 1000
size = "100k Items"
spec = "msgpack"
dt = timeit(lambda: msgpack.packb(items), number=100)
dt = timeit(lambda: msgpack.packb(items), number=number_default)
if args.json:
result["msgpack"].append({"algo": spec, "count": 100000, "time": dt})
else:
Expand Down
6 changes: 4 additions & 2 deletions src/borg/testsuite/archiver/benchmark_cmd_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ def test_benchmark_crud_json_lines(archiver, monkeypatch):
assert entry["io"] > 0


def test_benchmark_cpu(archiver):
def test_benchmark_cpu(archiver, monkeypatch):
monkeypatch.setenv("_BORG_BENCHMARK_CPU_TEST", "YES")
output = cmd(archiver, "benchmark", "cpu")
# verify all section headers appear in the plain-text output
assert "Chunkers" in output
Expand All @@ -57,7 +58,8 @@ def test_benchmark_cpu(archiver):
assert "msgpack" in output


def test_benchmark_cpu_json(archiver):
def test_benchmark_cpu_json(archiver, monkeypatch):
monkeypatch.setenv("_BORG_BENCHMARK_CPU_TEST", "YES")
output = cmd(archiver, "benchmark", "cpu", "--json")
result = json.loads(output)
assert isinstance(result, dict)
Expand Down