Skip to content

implement padme chunk size obfuscation (SPEC 250), fixes #8705#8718

Merged
ThomasWaldmann merged 3 commits intoborgbackup:masterfrom
div-dev123:feature/padme_obfuscate
Apr 5, 2025
Merged

implement padme chunk size obfuscation (SPEC 250), fixes #8705#8718
ThomasWaldmann merged 3 commits intoborgbackup:masterfrom
div-dev123:feature/padme_obfuscate

Conversation

@div-dev123
Copy link
Contributor

@div-dev123 div-dev123 commented Apr 4, 2025

Added Padmé padding as a new obfuscation option with SPEC=250.

@div-dev123
Copy link
Contributor Author

@ThomasWaldmann I have created this PR please see if it matches your expectations and let me know , after this ill create a new PR for com.apple issue
thanks!

@ThomasWaldmann
Copy link
Member

Can you please make a separate PR for the xattr fix?

@div-dev123
Copy link
Contributor Author

Yes will do so

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (d8a0601) to head (5608c1a).
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8718   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files          74       74           
  Lines       13348    13348           
  Branches     1971     1971           
=======================================
  Hits        10921    10921           
  Misses       1761     1761           
  Partials      666      666           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@div-dev123
Copy link
Contributor Author

Once this is merged ill create a new PR because my master branch also has these commits so any branch i create is ahead of the upstream so ill have a bit problems

@ThomasWaldmann
Copy link
Member

You should always keep your master branch clean (representing and in sync with upstream master), then things get way easier and you don't block yourself.

@div-dev123
Copy link
Contributor Author

Yeah I realised that now , its just that first time for all this so made a little mistakes. But thanks so much for you patience !

@div-dev123
Copy link
Contributor Author

@ThomasWaldmann can you squash the commits for this?

@ThomasWaldmann ThomasWaldmann merged commit d2066ed into borgbackup:master Apr 5, 2025
16 checks passed
@ThomasWaldmann
Copy link
Member

@div-dev123 can you also do a backport of this to 1.4-maint branch?

@div-dev123
Copy link
Contributor Author

Can you tell me how to do that? Like should i just push this commit there ? wont there be conflicts?

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Apr 6, 2025

You can use git cherry-pick for that. Sometimes, there will be conflicts, sometimes not. Conflicts need to get resolved manually.

@ThomasWaldmann
Copy link
Member

@div-dev123 are you still working on the backport?

@div-dev123
Copy link
Contributor Author

I have my exams till Friday, I can work after that but if anyone wants to work on it they can!

@ThomasWaldmann
Copy link
Member

I'll work on the 1.4 backport now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants