Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pytorch 2.0 & pytorch-lightning 2.0 #54

Open
alexandervaneck opened this issue Apr 11, 2023 · 3 comments · May be fixed by #61
Open

Allow pytorch 2.0 & pytorch-lightning 2.0 #54

alexandervaneck opened this issue Apr 11, 2023 · 3 comments · May be fixed by #61

Comments

@alexandervaneck
Copy link

Hi, I'm just getting started with pycave and would like to use pytorch 2.0. It's torch.compile mechanism could be really powerful.

Would you please allow your package to also allow 2.0 for both pytorch and pytorch-lightning?

Also, would you expected any speedups from using torch.compile?

Thank you! 🙇
@farisjanjos
Copy link

farisjanjos commented Oct 18, 2023 •
edited
Loading

Would also like to inquire if there are any plans to bump to pytorch-2.0 :) I'm planning to publish code for a recently submitted paper where we used PyCave (and cited it!). It would make our lives much easier if we could use torch 2.0 instead of fixing to torch1.12.1+cu116, which is what we had to use.

@borchero
Copy link
Owner

Would love to do that. Unfortunately, I haven't used the latest versions of PyTorch (Lightning) and torchmetrics so I will need some time to figure out relevant changes. If you want to provide some support fixing the CI for the latest versions, please go ahead 😅

@AndreasGerken
Copy link

Would love to use a higher version aswell.

EvenStrangest added a commit to EvenStrangest/pycave that referenced this issue Sep 28, 2024
@EvenStrangest
Allow pytorch 2.0 & pytorch-lightning 2.0 via Copilot Workspace
9e0aeb5 
Fixes borchero#54

Update the package to support PyTorch 2.0 and PyTorch-Lightning 2.0.

* **pyproject.toml**
  - Update `torch` version to "^2.0.0".
  - Update `pytorch-lightning` version to "^2.0.0".

* **.github/workflows/ci.yml**
  - Add Python 3.11 to the matrix of Python versions for unit tests.

* **pycave/bayes/gmm/lightning_module.py**
  - Update import for `EarlyStopping` to ensure compatibility with PyTorch-Lightning 2.0.

* **pycave/bayes/markov_chain/estimator.py**
  - Add import for `Trainer` from `pytorch_lightning`.

* **pycave/utils/lightning_module.py**
  - Update import for `pytorch_lightning` to `lightning.pytorch` to ensure compatibility with PyTorch-Lightning 2.0.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/borchero/pycave/issues/54?shareId=XXXX-XXXX-XXXX-XXXX).
@EvenStrangest EvenStrangest linked a pull request Sep 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow pytorch 2.0 & pytorch-lightning 2.0 (changes via Copilot Workspace) EvenStrangest/pycave
4 participants
@AndreasGerken @alexandervaneck @farisjanjos @borchero