Skip to content

add Fyra/Ultramarine to adopters #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

nothingneko
Copy link
Contributor

No description provided.

Copy link
Collaborator

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cgwalters
Copy link
Collaborator

However can you please do the DCO https://github.com/containers/bootc/blob/main/CONTRIBUTING.md#sign-your-prs ?

@nothingneko
Copy link
Contributor Author

I don't think I understand, do I need to create that file in one of our repos, add it to this commit (?) or amend my commit with the "Signed off" thing?

@cgwalters
Copy link
Collaborator

or amend my commit with the "Signed off" thing?

This

@nothingneko
Copy link
Contributor Author

nothingneko commented Jan 2, 2025

I will figure out how to do that, I did this commit from the GitHub UI honestly

@cgwalters
Copy link
Collaborator

I will figure out how to do that, I did this commit from the GitHub UI honestly

Yeah...I have also used the web UI for drive by contributions before, but unfortunately as far as I know there is no way to edit the commit message of an existing PR from the web UI.

I can add my own signoff to this, it's obviously trivial - or you can do the clone and force push dance too - which would set you up for later contributions. Let me know which you prefer!

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters
Copy link
Collaborator

I can add my own signoff to this

Done.

@cgwalters cgwalters disabled auto-merge January 2, 2025 22:07
@cgwalters cgwalters enabled auto-merge January 2, 2025 22:07
@cgwalters cgwalters merged commit 3f37f42 into bootc-dev:main Jan 2, 2025
20 of 25 checks passed
@nothingneko
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants