clippy: Deny str::len
#914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I was working on some column printing code with Unicode I got bit by using `str::len`...and digging in I found that clippy actually just merged a lint to go the *other* way; more in the link in the code. Turning on a lint showed one place that should have been using `chars().count()` and one that should have been validating ASCII. Fix those. Signed-off-by: Colin Walters <walters@verbum.org>
jeckersb
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was working on some column printing code
with Unicode I got bit by using
str::len...anddigging in I found that clippy actually just
merged a lint to go the other way; more in
the link in the code.
Turning on a lint showed one place that should
have been using
chars().count()and one thatshould have been validating ASCII. Fix those.