install: Two rootfs cleanups #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the install flow we have both `rootfs` and `rootfs_fd` which hold the physical root. Using fd-relative accesses where we can provides a lot of advantages, so switch most uses over to the file descriptor. Signed-off-by: Colin Walters <walters@verbum.org>
In the install flow we juggle *three* file systems in general: - The container/host root - The physical root - The deployment root "rootfs" in theory could be any of those three. In the install code it's the physical (target) root, so rename the variable to clarify. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
commented
Nov 19, 2024
| @@ -661,7 +661,6 @@ async fn initialize_ostree_root(state: &State, root_setup: &RootSetup) -> Result | |||
| )?; | |||
| } | |||
|
|
|||
| let sysroot = ostree::Sysroot::new(Some(&gio::File::for_path(rootfs))); | |||
There was a problem hiding this comment.
Note here we somehow ended up with two sysroot objects pointlessly, so this drops the second.
Hmm, I think the nushell update here in EPEL (from yesterday) broke our test scripts. Looking at this |
|
nushell/nushell#14333 is also related to this I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install: Reduce usage of absolute path for rootfs
In the install flow we have both
rootfsandrootfs_fdwhichhold the physical root. Using fd-relative accesses where we
can provides a lot of advantages, so switch most uses over
to the file descriptor.
Signed-off-by: Colin Walters walters@verbum.org
install: Rename rootfs -> physical_root
In the install flow we juggle three file systems in general:
"rootfs" in theory could be any of those three. In the install code
it's the physical (target) root, so rename the variable
to clarify.
Signed-off-by: Colin Walters walters@verbum.org