Skip to content

install-to-disk: Check for mounts before install #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

install-to-disk: Check for mounts before install #805

merged 1 commit into from
Oct 22, 2024

Conversation

djach7
Copy link
Contributor

@djach7 djach7 commented Sep 25, 2024

Works to improve bootc install to-disk flow by checking for mounts on the device to be installed to. If mounts are present then install will abort.

Resolves #720

cgwalters
cgwalters reviewed Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

@djach7 djach7 force-pushed the installToDisk branch 3 times, most recently from 738eb54 to eece03c Compare October 3, 2024 18:20
@djach7
Copy link
Contributor Author

djach7 commented Oct 3, 2024

This should be working now, I made changes to parse the findmnt output for the device and bail if found. @cgwalters for the findmnt command I hardcoded -N 1, is there any issue with that? I was attempting to pass it a pid (you can see that attempt in the wip commit if you're curious) but the pid being passed was unable to see the device I was attempting to mount to.

cgwalters
cgwalters requested changes Oct 7, 2024
View reviewed changes
@cgwalters
Copy link
Collaborator

Thanks for working on this BTW, I think it's getting close!

@github-actions github-actions bot added the area/install Issues related to `bootc install` label Oct 17, 2024
cgwalters
cgwalters reviewed Oct 17, 2024
View reviewed changes
@djach7
Check for existing mounts when installing to disk
89588ef 
Signed-off-by: djach7 <djachimo@redhat.com>
@djach7 djach7 requested a review from cgwalters October 22, 2024 13:05
@djach7 djach7 marked this pull request as ready for review October 22, 2024 13:05
@cgwalters cgwalters merged commit 4d816fa into bootc-dev:main Oct 22, 2024
24 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters approved these changes

Assignees
No one assigned
Labels
area/install Issues related to `bootc install`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

install to-disk: Check for mounts
2 participants
@djach7 @cgwalters