Reinstall prompt tweaks

[ckyrouac]

See commit messages, just some prompt tweaks to clarify usage of system-reinstall-bootc.

Closes: #1269

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

system-reinstall-bootc/src/prompt.rs:31

• [nitpick] The prompt message may be ambiguous if multiple keys are possible. Consider clarifying whether this message applies solely when a single key is imported or if it also applies when multiple keys are selected.

This is the key that will be used to access the bootc system.

system-reinstall-bootc/src/prompt.rs:31

• [nitpick] Since the multi-select prompt allows for choosing several keys, this singular phrasing may confuse users. It might help to adjust the wording to clarify how the selected key is used or if only one can be effective.

This is the key that will be used to access the bootc system.

[cgwalters]

Nothing blocking really, OK to merge as is

[cgwalters]

Just thinking about this more...I wonder if we should instead default to rebooting, with the option to press e.g. ctrl-c/escape to exit?

We already prompt them in temporary_developer_protection_prompt "hey this will replace your system" earlier so I think we could actually change it to say...

diff --git i/system-reinstall-bootc/src/prompt.rs w/system-reinstall-bootc/src/prompt.rs
index 6308450a..ec73ae85 100644
--- i/system-reinstall-bootc/src/prompt.rs
+++ w/system-reinstall-bootc/src/prompt.rs
@@ -44,7 +44,7 @@ pub(crate) fn temporary_developer_protection_prompt() -> Result<()> {
     // Print an empty line so that the warning stands out from the rest of the output
     println!();
 
-    let prompt = "THIS WILL REINSTALL YOUR SYSTEM! Are you sure you want to continue?";
+    let prompt = "NOTICE: This will replace the installed operating system and reboot. Are you sure you want to continue?";
     let answer = ask_yes_no(prompt, false)?;
 
     if !answer {

And then here at the end we have a timer like:

Operation complete, rebooting in {n} seconds. Press Ctrl-C to cancel reboot, any other key to continue immediately.

With a value of n=10 perhaps?

[cgwalters]

"bootc system" stutters here. I wonder if we even need to clarify "bootc" system in this context, I think it's implicitly understood. Maybe:

Would you like to copy the SSH authorized keys for the root user on the new system? Then you can log in as root@ using those keys.

[cgwalters]

We were playing with this but it isn't quite right

+pub(crate) async fn reboot() -> Result<()> {
+    let delay_seconds = 10;
+    println!(
+        "Operation complete, rebooting in {delay_seconds} seconds. Press Ctrl-C to cancel reboot, or press enter to continue immediately.",
+    );
+
+    let event = crossterm::event::EventStream::new();
+    tokio::pin!(event);
+    let event = event.next();
+    let timeout = tokio::time::timeout(Duration::from_secs(delay_seconds), event);
+    timeout.await?;
+    Ok(())
+}
+

[cgwalters]

quay.io bad gateway is ruining our CI 😦