install: Deprecate skip-fetch-check, replace with run-fetch-check #1256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- hack/lldb/deploy.sh: Language not supported
Comments suppressed due to low confidence (2)
lib/src/install.rs:1297
- The deprecation warning references '--skip-check-fetch' instead of the correct '--skip-fetch-check'. Please update the message for consistency.
tracing::warn!("--skip-check-fetch is deprecated and will be removed in a future version");
docs/src/man/bootc-install-to-filesystem.md:105
- [nitpick] There is trailing whitespace in the '--run-fetch-check' flag documentation; consider removing it for clarity.
**\--run-fetch-check **
ckyrouac
force-pushed
the
run-fetch-check
branch
from
051850f to
b1e9e12
Compare
github-actions
bot
added
documentation
This deprecates skip-fetch-check in favor of the inverse, run-fetch-check. Updates docs and tests to reflect the change. Signed-off-by: ckyrouac <ckyrouac@redhat.com>
ckyrouac
force-pushed
the
run-fetch-check
branch
from
b1e9e12 to
44ce2cf
Compare
ckyrouac
changed the title
cgwalters
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates skip-fetch-check in favor of the inverse, run-fetch-check. Updates docs and tests to reflect the change.
Spawned from #1255 (comment). Opening this for discussion. Also, I'm not sure how to properly deprecate an argument so I just took a stab at it.