Skip to content

Two changes for bootc-status-updated.path #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

cgwalters
Copy link
Collaborator

build-sys: Enable bootc-status-updated.path by default

Followup to #977

In chatting with John we had some agreement to statically
enable the .path unit by default upstream here since
it's a feature we want to be available by default
so that tooling can react dynamically to changes.

Signed-off-by: Colin Walters walters@verbum.org


bootc-status-updated: Add ConditionPathExists=/run/ostree-booted

This is a general best practice for our units to ensure
they don't apply outside of bootc systems.

Signed-off-by: Colin Walters walters@verbum.org


Followup to bootc-dev#977

In chatting with John we had some agreement to statically
enable the `.path` unit by default upstream here since
it's a feature we want to be available by default
so that tooling can react dynamically to changes.

Signed-off-by: Colin Walters <walters@verbum.org>
This is a general best practice for our units to ensure
they don't apply outside of bootc systems.

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters cgwalters requested a review from jeckersb January 6, 2025 20:31
@cgwalters cgwalters enabled auto-merge January 6, 2025 21:46
Copy link
Contributor

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters cgwalters merged commit ac27e42 into bootc-dev:main Jan 7, 2025
25 checks passed
Copy link
Collaborator

@jeckersb jeckersb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants