reinstall CLI doesn't work with older bootc images

[omertuc]

The reinstall podman commandline assumes the bootc image being installed includes the #919 change

This is an unnecessary assumption that makes it impossible to use with older bootc images

[omertuc]

To solve this we simply need to add the mounts to the commandline instead of assuming bootc will handle them itself

[cgwalters]

Yeah, that's easy enough to do here. But hopefully in the more medium term we can just rely on updated bootc in the target.

[omertuc]

Yeah, that's easy enough to do here. But hopefully in the more medium term we can just rely on updated bootc in the target.

Yeah agreed

[cgwalters]

We have https://github.com/containers/bootc/blob/5309d5b31b57027df917c97271f628f28ed59b2b/system-reinstall-bootc/src/podman.rs#L22 right?

[omertuc]

That's just one of them, I guess we should have all?

So also -v /dev:/dev and --security-opt label=type:unconfined_t (?)

[ckyrouac]

I'll test this with an old bootc image and see what we need. I'd like to also add a tmt test to gate on this if that makes sense.

[cgwalters]

I'll test this with an old bootc image and see what we need.

Everything from the current docs I'd say - in #919 I explicitly didn't drop the bits from the documentation because of this reason, not everyone would have the new bootc right away.

I'd like to also add a tmt test to gate on this if that makes sense.

Definitely 👍 to testing, though I think we are missing a tmt test for system-reinstall-bootc at all; this would be a special case.

But the immediate problem with any automated tests and system-reinstall-bootc is that it's an interactive tool, so we would need to either:

• Drive it via an answer file (simpler, most obvious)
• Actually script interacting with the TUI (harder, but tooling exists)

[omertuc]

Actually script interacting with the TUI (harder, but tooling exists)

Be mindful of console-rs/dialoguer#170