-
Notifications
You must be signed in to change notification settings - Fork 100
Support github enterprise release urls for ISO #339
Conversation
fmt.Printf("Latest release for %s/%s is %s\n", org, repo, tag) | ||
url = fmt.Sprintf("https://github.com/%s/%s/releases/download/%s/boot2docker.iso", org, repo, tag) | ||
if host == "api.github.com" { | ||
url = fmt.Sprintf("https://github.com/%s/%s/releases/download/%s/boot2docker.iso", org, repo, tag) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this slightly simpler, couldn't this block of the if
just set host = "github.com"
and then move the second url = ...
outside the else
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Done
@SvenDowideit Any thoughts on this? Is there a chance for this to be included? Btw the travis build failure seems like an intermittent unrelated one. |
The Travis failure will be fixed if you rebase on master. 👍 |
+1 -- we will also add this to machine too. |
Thanks @ehazlett ❤️ LGTM @databus23 if you can rebase on master so we can have this hit Travis for a once-over compile test, I think we're ready to merge 👍 |
yw |
5f3fc03
to
bdae52f
Compare
Just rebased on master. We have a go from Travis... |
Thanks! 👍 |
Support github enterprise release urls for ISO
This adds support for
ISOURL
pointing to GitHub Enterprise release API urls.So this makes the reggae to match
https://api.github.com/repos/$ORG/$REPO/releases
https://some.host/api/v3/$ORG/$REPO/releases
Background: We need to maintain a fork of the boot2docker.iso on our internal github applicance to make it work inside our sealed corporate network. Having the
boot2docker download
andboot2docker upgrade
work for us would be a blast.Cheers