Skip to content
This repository has been archived by the owner on Feb 27, 2018. It is now read-only.

Commit

Permalink
Explicitly use the VirtualBox NAT DNS Proxy
Browse files Browse the repository at this point in the history
  • Loading branch information
@tianon
tianon committed Dec 1, 2014
1 parent 2fb5d0a commit 4c59138
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion virtualbox/machine.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -633,10 +633,14 @@ func (m *Machine) Modify() error {
"--firmware", "bios",
"--bioslogofadein", "off",
"--bioslogofadeout", "off",
"--natdnshostresolver1", "on",
"--bioslogodisplaytime", "0",
"--biosbootmenu", "disabled",

// VirtualBox's DNS Host Resolver doesn't support SRV records
// direct DNS pass-through doesn't support roaming laptops well
// so we explicitly enable the DNS proxy
"--natdnsproxy1", "on",

"--ostype", m.OSType,
"--cpus", fmt.Sprintf("%d", m.CPUs),
"--memory", fmt.Sprintf("%d", m.Memory),
Expand Down

2 comments on commit 4c59138

@sorccu
Copy link

@sorccu sorccu commented on 4c59138 Dec 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change has made DNS resolving (inside the VM) take 2-5 seconds every single time on my MacBookPro11,3. I'm running boot2docker 1.3.3 with 1.3.3 ISO, Docker 1.3.3 and VirtualBox 4.3.20 on OS X 10.10.1. This seems to suggest that I'm not the only one experiencing these issues with the resolver.

@tianon
Copy link
Contributor Author

@tianon tianon commented on 4c59138 Dec 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #320. 👍

Please sign in to comment.