Upgrade dependencies to fix test failures on JDK 11. #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundbp
force-pushed
the
fix-for-jdk11
branch
from
477ae99 to
6a1f675
Compare
The toArray method is now overloaded and requires type hints, and through transitive depencies the boot-alt-test dependency dragged in an old version of core.rrb-vector breakin the build on jdk11.
sundbp
force-pushed
the
fix-for-jdk11
branch
from
6a1f675 to
ca03c05
Compare
|
I guess you should rebase on top of |
Closed
|
done - the failure now is because the travis run for jdk12 doesn't manage to install a JDK. unrelated to this issue (and we see it passes on 11 and 13 so v likely to be fine on 12 as well). |
bbatsov
reviewed
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The toArray method is now overloaded and requires type hints, and through
transitive depencies the boot-alt-test dependency dragged in an old version of
core.rrb-vector breakin the build on jdk11+.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: