Fix missing includes in match_manip.hpp
#767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lastique
force-pushed
the
feature/fix_missing_includes
branch
from
449fdbd
to
f00a896
Compare
|
This misses a couple of other uses of |
Use failbit as a dependent name to avoid having to include <ios> for std::ios_base::failbit. Add missing includes for enable_if, mpl::true_/mpl::false_ and scoped enums.
Lastique
force-pushed
the
feature/fix_missing_includes
branch
from
f00a896
to
880efca
Compare
|
I've added a few more workarounds, but it looks like missing includes are all over Boost.Spirit. This PR is not meant to be an exhaustive fix for this problem, just something I found during the switch to |
|
On October 8, 2023 12:29:09 PM Alexander Grund ***@***.***> wrote:
Interesting that you seem to have required more changes, I added [much less
](b7e03f7)
to make the [test PR](#774/) pass
My original set of changes were enough to get the tests passing for me. The
added ones are what you pointed out and what caught my eye while I was
fixing those.
|
I see makes sense. I tested your changes in #774 and it passes CI so this is good to merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
failbitas a dependent name to avoid having to include<ios>forstd::ios_base::failbit.Add missing includes for
enable_ifandmpl::true_/mpl::false_.