make sub_match usable with Boost.Range #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch - as noted in the issue wouldn't begin() and end() member functions be a better bet? |
|
I did it the same as is done in xpressive's sub_match where I believe it was done like that because of compatibility with the C++ standard (can't verify that last as I don't have a copy of the latest C++ standard handy). Myself I don't really have a preference in either direction. |
|
Fixed slightly differently in Git develop, closing. |
This was referenced Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements this suggestion, i.e. it makes sub_match usable as a range in the least intrusive way: https://svn.boost.org/trac/boost/ticket/11036