Error in documentation (*it).prefix().last

[Necktschnagge]

I'm not yet 100% sure that there is no mistake that I did, but using regex_iterator as of 1.71.0 the documentation says there is a member last (*it).prefix().last.
This should be the corresponding line:

regex/doc/regex_iterator.qbk

Line 133 in c3ab640

[[`(*it).prefix().last`][The same as the start of the match found:

But my compiler complains that there is no member last.
Instead I could find some member end() which seems to what was described for last.
This issue also appears for (*it).suffix().last
However, ~.first works as in the documentation.
But there is also a .begin() doing apparently the same.

[jzmaddock]

The type of (*it).prefix() and (*it).suffix() is a std::pair<>, as such it has members .first and .second and no .begin() or .end(). Can you post a test case that demonstrates the issue?

[Necktschnagge]

As I just tested, you are right when you say, there is a .first and a .second.
Then the documentation is just wrong which states existence of first and last.

This works for me, so there is indeed also some begin() and end():

		using regex_iterator = boost::regex_iterator<std::string::const_iterator>;
		using pos = std::string::const_iterator;


		std::string example = "one two three four five";
		auto two = boost::regex("two");
		auto it = regex_iterator(example.cbegin(), example.cend(), two);
		if (it != regex_iterator()) {
			const pos two_begin{ it->prefix().end() };
			const pos two_end{ it->suffix().begin() };
			const pos two_begin2{ it->prefix().second };
			const pos two_end2{ it->suffix().first };
			for (auto i = two_begin; i != two_end; ++i) std::cout << (*i);
			for (auto i = two_begin2; i != two_end2; ++i) std::cout << (*i);
		}

Also, my compiler says that it->suffix() is of type boost::sub_match<...> and not std::pair<...>.

[jzmaddock]

As I just tested, you are right when you say, there is a .first and a .second.
Then the documentation is just wrong which states existence of first and last.

Oh, somehow my brain automatically changed .last to .second without my noticing :(

So yes you are quite right, and this mistake crops up all over. Fixed in develop now.

Also, my compiler says that it->suffix() is of type boost::sub_match<...> and not std::pair<...>.

Yes that's also quite correct.

[Necktschnagge]

OK, thank you!