Fix conversion of PyUnicodeObject to wstring #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanseefeld
requested changes
Dec 13, 2016
Member
stefanseefeld
left a comment
stefanseefeld
left a comment
There was a problem hiding this comment.
Hi Tadeu,
thanks for the patch !
May I ask for two changes:
-
please submit the fix for the test_builtin_converters.py test separately (with a message indicating the bug this fixes).
-
please add a comment to the conditional explaining why PyObject_Length doesn't work (in that case).
(Just putting the explanation from this pull request itself is fine. The point is to let people reviewing the code understand why this is needed.)
Thanks !
On Windows, with Python >= 3.3, `PyObject_Length` cannot be used to get the size of the `wchar_t` string, because it will count the number of *code points*, but some characters not on the BMP will use two UTF-16 *code units* (surrogate pairs). This is not a problem on Unix, since `wchar_t` is 32-bit.
tadeu
force-pushed
the
fix-wstring-conversion
branch
from
20b8418 to
942fb68
Compare
Contributor
Author
|
@stefanseefeld Of course, I've just made the changes, thanks! |
Member
|
Many thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, with Python >= 3.3,
PyObject_Lengthcannot be used to getthe size of the
wchar_tstring, because it will count the number ofcode points, but some characters not on the BMP will use two UTF-16
code units (surrogate pairs).
This is not a problem on Unix, since
wchar_tis 32-bit.This also fixes a problem where
test_builtin_converters.pywas notbeing run, since the module docstring was not the first statement.