Skip to content

Fix homebrew include path. - #472

Merged
stefanseefeld merged 2 commits into
developfrom
macos
Feb 2, 2025
Merged

stefanseefeld merged 2 commits into
developfrom
macos

Conversation

@stefanseefeld

Copy link
Copy Markdown
Member

No description provided.

@pdimov

pdimov commented Feb 1, 2025

Copy link
Copy Markdown
Member

This seems to have worked, but the build now fails for a different reason, Optional requires C++11. I see that the command line passes cxxflags=-std=c++11, but then the log says

configuration check results:
  has_cxx11 : False 
  has_numpy : False 

so it looks like this doesn't take for some reason.

Maybe faber should be modified to print the command line on failure, like b2 does.

The problem could be that the makedep rule doesn't apply cxxflags.

@stefanseefeld
stefanseefeld merged commit 4fe3403 into develop Feb 2, 2025
@stefanseefeld

stefanseefeld commented Feb 2, 2025 •

Copy link
Copy Markdown
Member Author

Good catch @pdimov . Indeed, faber uses the cppflags feature to configure the pre-processor, and cxxflags for the (C++) compiler. Setting the -std option in both has fixed the build problem. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants